-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring in email preferences page from lbry.com #4409
Conversation
@kauffj This works when signed in, or if a
|
1d5b1bf
to
587c1a1
Compare
/> | ||
<> | ||
<Card | ||
title={__('Notifications')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could introduce tabs to settings instead of this? (not blocking feedback, can evolve)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This definitely a step towards some tabbed/nested setting page.
{enabledEmails.map(({ email, isEnabled }) => ( | ||
<FormField | ||
type="checkbox" | ||
name={`active-email:${email}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this safe for all potential emails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It's just used for the input label for screen readers
|
||
{enabledEmails && enabledEmails.length > 0 && ( | ||
<Card | ||
title={__('Receiving Addresses')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many people will have one email, probably worth making this conditional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Will change.
The notifications PR was already pretty big so I decided to strip this out and make a PR for this separately.